Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error #353 and #351 #354

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Conversation

Heavenfighter
Copy link
Contributor

@Heavenfighter Heavenfighter commented Dec 1, 2024

Issue #, if available:
#353

Description of changes:
changed css selector

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…n 5 seconds.

Since deleting ad is redirecting to ad overview, the check for element "chhcking-done" has to be done first.
@Heavenfighter Heavenfighter changed the title fix No HTML element found using CSS selector '[class*="jsx-2623555103"] Fix for error #353 and #351 Dec 1, 2024
@Heavenfighter
Copy link
Contributor Author

#351
The order has to be changed when checking for element and deleting old ad

@1cu
Copy link

1cu commented Dec 1, 2024

Works like a charm 👍

@DreckSoft
Copy link
Contributor

DreckSoft commented Dec 7, 2024

After applying your patch, the old ad does no longer get deleted when re-publishing unless you set the config to BEFORE_PUBLISH.

@Heavenfighter
Copy link
Contributor Author

Hmm thats strange, i have no problems when republishing ads. The old are deleted.

@sebthom sebthom merged commit 9a82645 into Second-Hand-Friends:main Dec 8, 2024
11 checks passed
@sebthom
Copy link
Contributor

sebthom commented Dec 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants